Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Nov 13, 2025

Add a import-untyped for snakeviz in the case it is installed.

Signed-off-by: [email protected]
Change-Id: Ia951a0013d09e06c0d29a32bdb6b49ae11561d7d

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@perheld perheld requested a review from Gasoonjia as a code owner November 13, 2025 08:36
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Nov 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15806

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit 4ea0bce with merge base 65d4b94 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 13, 2025
Add a import-untyped for snakeviz in the case it is installed.

Signed-off-by: [email protected]
Change-Id: Ia951a0013d09e06c0d29a32bdb6b49ae11561d7d
@zingo
Copy link
Collaborator

zingo commented Nov 17, 2025

Hi @metascroy here is one PR outside or Arm stuff we might want help to review!

@meta-codesync
Copy link

meta-codesync bot commented Nov 19, 2025

@metascroy has imported this pull request. If you are a Meta employee, you can view this in D87489291.

@zingo
Copy link
Collaborator

zingo commented Nov 20, 2025

Rebased to make sure the cortex-m size test has been fixed. This PR should not in any way cause problems in it but its nice to prove green CI on all Arm tests.

@zingo
Copy link
Collaborator

zingo commented Nov 20, 2025

@metascroy I rebased this after your import and need a re-import, Thinking about about it the rebase was a bit stupid but now its done. Sorry for the extra work.

@metascroy
Copy link
Contributor

Hi @metascroy here is one PR outside or Arm stuff we might want help to review!

The internal tests look good if you want to merge

@zingo zingo merged commit 23fc78f into pytorch:main Nov 21, 2025
295 of 302 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants